Use bulk conversion in Write8BitColor #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ReadOnlySpan<TPixel> quantizedColors = quantized.Palette.Span; | ||
| var color = default(Rgba32); | ||
| PixelOperations<TPixel>.Instance.ToRgba32(Configuration.Default, quantizedColors, rgbColors); |
There was a problem hiding this comment.
This should be the configuration that the memory allocator is derived from.
antonfirsov
reviewed
Nov 15, 2020
Comment on lines
342
to
349
| using IMemoryOwner<Rgba32> rgbColorsBuffer = this.memoryAllocator.Allocate<Rgba32>(quantized.Palette.Length); | ||
| Span<Rgba32> rgbColors = rgbColorsBuffer.GetSpan(); | ||
|
|
||
| ReadOnlySpan<TPixel> quantizedColors = quantized.Palette.Span; | ||
| var color = default(Rgba32); | ||
| PixelOperations<TPixel>.Instance.ToRgba32(Configuration.Default, quantizedColors, rgbColors); | ||
|
|
||
| // TODO: Use bulk conversion here for better perf | ||
| int idx = 0; | ||
| foreach (TPixel quantizedColor in quantizedColors) | ||
| foreach (Rgba32 color in rgbColors) |
There was a problem hiding this comment.
Why not something like:
PixelOperations<TPixel>.Instance.ToRgba32(Configuration.Default, quantizedColors, MemoryMarshal.Cast<byte, Rgba32>(colorPalette));
ref Span<uint> colorPaletteAsUInt= MemoryMarshal.Cast<byte, uint>(colorPalette);
for (int i =0;i<colorPaletteAsUInt;i++)
colorPaletteAsUInt[i] = colorPaletteAsUInt[i] & 0xFFFFFF00;There was a problem hiding this comment.
yeah that will do, it just needs to be ToBgra instead
There was a problem hiding this comment.
Which should be fast enough with the new shuffle intrinsics
brianpopow
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
- Coverage 83.08% 83.08% -0.01%
==========================================
Files 707 707
Lines 31839 31834 -5
Branches 3590 3590
==========================================
- Hits 26454 26449 -5
Misses 4668 4668
Partials 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JimBobSquarePants
approved these changes
Nov 16, 2020
JimBobSquarePants
added a commit
that referenced
this pull request
Mar 13, 2021
Use bulk conversion in Write8BitColor
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Just a small improvement in writing 8 bit bitmaps with a palette: Converting the quantized colors to rgb is now done as bulk convert.